Merge pull request #275 from tellerops/fix-dotenv-quote

Fix dotenv quote
tellerops · May 15, 2024 · 9186cfb · 9186cfb
2 parents 5064e4e + ad55573
commit 9186cfb
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/teller-cli/fixtures/flow_test_vars.env b/teller-cli/fixtures/flow_test_vars.env
@@ -1 +1,2 @@
+FOO="bar baz"
 USER_NAME=linus
diff --git a/teller-cli/tests/snapshots/flow_test__flow-test-dot-0.snap b/teller-cli/tests/snapshots/flow_test__flow-test-dot-0.snap
@@ -4,6 +4,31 @@ expression: res
 ---
 Ok(
     [
+        KV {
+            value: "bar baz",
+            key: "FOO",
+            from_key: "FOO",
+            path: Some(
+                PathInfo {
+                    id: "tvars",
+                    path: "fixtures/flow_test_vars.env",
+                },
+            ),
+            provider: Some(
+                ProviderInfo {
+                    kind: Dotenv,
+                    name: "dot_1",
+                },
+            ),
+            meta: Some(
+                MetaInfo {
+                    sensitivity: None,
+                    redact_with: None,
+                    source: None,
+                    sink: None,
+                },
+            ),
+        },
         KV {
             value: "linus",
             key: "USER_NAME",

diff --git a/teller-providers/src/providers/dotenv.rs b/teller-providers/src/providers/dotenv.rs
@@ -110,7 +110,11 @@ fn save(path: &Path, data: &BTreeMap<String, String>) -> Result<String> {
         };
 
         let value = json_value.unwrap_or_else(|| v.to_string());
-        out.push_str(&format!("{k}={value}\n"));
+        if value.chars().any(char::is_whitespace) && !value.starts_with(['"', '\'']) {
+            out.push_str(&format!("{k}=\"{value}\"\n"));
+        } else {
+            out.push_str(&format!("{k}={value}\n"));
+        }
     }
 
     fs::write(path, &out)?;