fix: change package scope to @progress #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Only compatible with GH Actions
kspeyanski
reviewed
Jun 2, 2022
There was a problem hiding this comment.
Should we use secrets.NPM_TOKEN instead of NPM_TOKEN_TELERIK in cd.yml?
I'm suspicious that both tokens would have access to the @progress scope, but I may be wrong.
|
Good catch, they're separate. |
kspeyanski
approved these changes
Jun 2, 2022
|
Published a 3.0.0 version manually so semantic release can hopefully take off from there 🤞🏽 The package is still not visible in the registry, but is installable. I f-ed up a bit by un-publishing the only version of the new version and it's now in a 24-hour cool-down period during which it doesn't officially exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the
@telerikscope for internal usage.Will publish this as
@progress/semantic-prereleasev3.0.0