Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update semantic-release version #25

Closed
wants to merge 2 commits into from

Conversation

kspeyanski
Copy link
Contributor

We have recently received a security-vulnerability notification from dependabot in the kendo-react-private repository, about CVE-2020-26226. Due to the way dependabot works (checks for vulnerabilities after a commit), we would be seeing the notification in other repositories soon.

Updating the package to version 17.2.3 would be enough for patching the vulnerability and should not require any changes from our side (at least from my local testing). Updating to latest(18) would require us to bump the node version ot >14 which I'm afraid is not possible at the moment.

Copy link
Contributor

@ipeshev ipeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will break what could be broken.

@kspeyanski
Copy link
Contributor Author

Any ideas of how can we further test this without breaking every single repo in the organization?

@ipeshev
Copy link
Contributor

ipeshev commented Nov 25, 2021

Branch and release in different channel semantic-prerelease@break, but before that heavy local testing, for major packages in various suites.

@kspeyanski
Copy link
Contributor Author

The latest commit adds dependencies which were present in v6 of semantic-release but not in v17 and we're still somewhat using them.

The semantic-release-dry-run command in the kendo-react-private repo works with MISSING GITHUB/NPM TOKEN error, which is somewhat expected as I'm intentionally not passing them to avoid accidental release from my local machine.

@tsvetomir
Copy link
Member

Migration to the latest semantic release version is a noble idea, but it would take a deep look into how their plugin system works now.

The CVE has no impact on customers whatsoever, as it only concerns build logs which are private to us.

@kspeyanski
Copy link
Contributor Author

@tsvetomir Do you suggest ignoring the warning for now?

I'm totally OK with this, but wanted to start out a discussion, even if a PR was not the best place for it.

@tsvetomir
Copy link
Member

tsvetomir commented Aug 28, 2023

Closing, ad it's not possible to override the major version from a plugin in the latest semantic-release versions.
See semantic-release/semantic-release#1507 and semantic-release/semantic-release#2641.

@tsvetomir tsvetomir closed this Aug 28, 2023
@tsvetomir tsvetomir deleted the update-semantic-release-version branch August 28, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants