-
-
Notifications
You must be signed in to change notification settings - Fork 253
Enhancement/add unit tests #34
Enhancement/add unit tests #34
Conversation
ba7c44c
to
2eb77e9
Compare
@dwisiswant0 Could you please check my code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fairyhunter13, I confirm to request changes & some revisions for tests you are working on.
Please note that the closing issue that you mention is for the whole part of the test, considering this PR is only partially done, I suggest to change this summary TO NOT use closing keywords - but you can still link to issue #32 to track the progress of that issue ticket.
adc39a7
to
8c48f33
Compare
@dwisiswant0 Could you please check my PR again? |
bd0b643
to
67a206b
Compare
This looks lit @fairyhunter13. Mad thanks for your contributions & of course for your efforts, merging soon. 🔥 |
I've put up a pull request to add @fairyhunter13! 🎉 |
@dwisiswant0 Sorry for my inexperience in contributing to the open-source project. Thank you for your reviews and hard work. Please keep it up! 👍 👍 👍 |
IMPORTANT: Please do not create a Pull Request without creating an issue first!
(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).
Summary
Explains the information and/ motivation for making this changes...
Adding partial unit tests on the
matchers
packageProposed of changes
This PR fixes/implements the following bugs/features:
How has this been tested?
Proof:
Closing issues
Checklist: