feat(accordion): allow collapsible to be individually expanded #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeridianGH
requested review from
maomaoZH,
acstll and
felix-ico
as code owners
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maomaoZH
approved these changes
Mar 4, 2024
|
@MeridianGH great job, can you please rebase it with the main branch so the checks can run for your changes and if they are all green we can merge this. Sorry for the long wait |
amir-ba
changed the title
A collapsible can now be individually expanded, independent of its containing accordion.
alright, thank you. the pr should be rebased now, can you check if the pipelines run correctly and if the pr is able to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collapsible can now be individually expanded, independent of its containing accordion.
The
expandedprop is now only propagated, if it is set to true on the parent accordion. This allows the developer to individually select which collapsibles should start expanded instead of all or none.This change works seamlessly with the
dependentprop and does not introduce any breaking changes.