-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add configuration for resource requests and limits, remove kubernetes manifest #67
Re-add configuration for resource requests and limits, remove kubernetes manifest #67
Conversation
…tes manifest - The resource configuration moved out, due to usage of the helmify command - I have also not found a way to configure it the way we need it - removing manifests in deploy/ so we do not need to maintain two sets of config - we could think about automating it
Well, it was automated. :) |
But generating the helm chart from the deployment manifests using helmify is currently dropping configuration. How do we want to proceed here? |
I'd be fine with generating the deploy-files from the helm-charts or modifying helmify so it does not drop the configuration. NB: not everybody uses (or likes) helm and I want to support that. Removing the static files would also be a breaking change. |
Hm, you completely removed the documentation on how to use it without helm. Can you re-add this please? |
Sure, done! |
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
From my point of view there is also no real benefit of storing the deploy manifests in the repo, if there is manual configuration required (adapting url and secret). If we could get around that, I'd love to generate a "deployment.yaml" and attach it to the release, like cert-manager does it for instance.