Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cleanups #23

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Feature/cleanups #23

merged 2 commits into from
Apr 10, 2024

Conversation

hwipl
Copy link
Contributor

@hwipl hwipl commented Apr 5, 2024

  • Fix linter warnings
  • Update package comment in TND example

Copy link

github-actions bot commented Apr 5, 2024

Test Result

🙌 37 Tests pass

Test Details

🟢 TestIsResolvConfEvent (0.00s)
🟢 TestWatchStartEvents (0.00s)
🟢 TestWatchStartStop (0.02s)
🟢 TestWatchStartStop/watcher_error (0.00s)
🟢 TestWatchStartStop/add_dir_error (0.00s)
🟢 TestWatchStartStop/no_errors (0.02s)
🟢 TestNewWatch (0.00s)
🟢 TestServerCheck (0.01s)
🟢 TestNewServer (0.00s)
🟢 TestWatchStartEvents (0.00s)
🟢 TestWatchStartStop (0.00s)
🟢 TestWatchStartStop/subscribe_error (0.00s)
🟢 TestWatchStartStop/no_errors (0.00s)
🟢 TestWatchProbes (0.00s)
🟢 TestNewWatch (0.00s)
🟢 TestConfigValid (0.00s)
🟢 TestNewConfig (0.00s)
🟢 TestDetectorSetGetServers (0.00s)
🟢 TestDetectorSetGetDialer (0.00s)
🟢 TestDetectorProbe (2.01s)
🟢 TestDetectorHandleProbeRequest (0.00s)
🟢 TestDetectorHandleProbeResult (0.00s)
🟢 TestDetectorHandleTimer (0.00s)
🟢 TestTNDStartStop (0.00s)
🟢 TestTNDStartStop/routes_watch_error (0.00s)
🟢 TestTNDStartStop/files_watch_error (0.00s)
🟢 TestTNDStartStop/no_errors (0.00s)
🟢 TestTNDProbe (0.00s)
🟢 TestTNDResults (0.00s)
🟢 TestNewTND (0.00s)
🟢 TestDetectorSetGetServers (0.00s)
🟢 TestDetectorSetGetDialer (0.00s)
🟢 TestDetectorStart (0.00s)
🟢 TestDetectorStop (0.00s)
🟢 TestDetectorProbe (0.00s)
🟢 TestDetectorResults (0.00s)
🟢 TestNewDetector (0.00s)

Coverage

Total coverage: 🟩🟩🟩🟥 85.5%

Coverage Details
Coverage File Uncovered Lines
🟥🟥🟥🟥 0.0% /examples/tnd/main.go 20-61
🟩🟩🟩🟩 95.1% /internal/files/watch.go 57-59, 80-82
🟩🟩🟩🟥 81.8% /internal/https/server.go 40-42, 44-46, 49-53
🟩🟩🟩🟩 100.0% /internal/routes/watch.go 29-29
🟩🟩🟩🟩 100.0% /pkg/tnd/config.go
🟩🟩🟩🟩 95.8% /pkg/tnd/detector.go 179-180, 183-185, 212-215, 222-222

@hwipl hwipl requested review from jandd and malaupa April 5, 2024 16:28
@hwipl hwipl force-pushed the feature/cleanups branch from 821329e to 2ac79b4 Compare April 10, 2024 12:31
@hwipl hwipl merged commit 794bb67 into main Apr 10, 2024
1 check passed
@hwipl hwipl deleted the feature/cleanups branch April 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants