-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource for Entra ID administrator #9
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also mind updating the README.md and adding an example to the https://github.com/telekom-mms/terraform-azurerm-database/blob/54b5291d99b50b4345ba0cca0a0579f598f6e7a3/examples/full_main.tf ?
Thanks!
resource "azurerm_mysql_flexible_server_active_directory_administrator" "mysql_flexible_server_active_directory_administrator" { | ||
for_each = var.mysql_flexible_server_active_directory_administrator | ||
|
||
server_id = var.mysql_flexible_server_active_directory_administrator[each.key].server_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the other resources, there were mainly locals used. I think for consistency, this should be adapted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md will be automatically updated via the GitHub action teraform-docs once the PR has been merged. For a useful example of mysql_flexible_server_active_directory_administrator in full_main.tf, additional resources (e.g. user_managed_identity) are required, which would have to be provided using other modules. I'll see if I can add an example.
For the other resources in this module, default values for optional arguments are set in locals. For this resource, all arguments are necessary for mysql_flexible_server_active_directory_administrator (see https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/mysql_flexible_server_aad_administrator#arguments-reference). That's why I didn't use locals here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough explanation! 🙂
Added the possibility to configure the resource mysql_flexible_server_active_directory_administrator in this module.