Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments #61

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix comments #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f2b028
internal/vpncscript: fix typo in comment
hwipl Mar 13, 2024
c14c962
internal/dnsproxy: fix comments
hwipl Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/dnsproxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (p *Proxy) handleRequest(w dns.ResponseWriter, r *dns.Msg) {
continue
}

// get TTL and enforce minimum TTL
// get TTL
ttl := a.Header().Ttl

switch a.Header().Rrtype {
Expand All @@ -93,7 +93,7 @@ func (p *Proxy) handleRequest(w dns.ResponseWriter, r *dns.Msg) {
report.Wait()

case dns.TypeCNAME:
// CNAME recort, store temporary watch
// CNAME record, store temporary watch
rr, ok := a.(*dns.CNAME)
if !ok {
log.Error("DNS-Proxy received invalid CNAME record in reply")
Expand Down
2 changes: 1 addition & 1 deletion internal/vpncscript/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func createConfigSplit(env *env, config *vpnconfig.Config) error {
// set dns excludes
config.Split.ExcludeDNS = env.dnsSplitExc

// set exclude virtual subnets only IPv5 flag
// set exclude virtual subnets only IPv4 flag
config.Split.ExcludeVirtualSubnetsOnlyIPv4 =
env.bypassVirtualSubnetsOnlyV4

Expand Down
Loading