Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set user_groups in notification to empty list #255

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

rndmh3ro
Copy link
Collaborator

in previous versions, the default was None, now it is an empty list. this would produce a diff

@rndmh3ro rndmh3ro marked this pull request as ready for review April 19, 2024 08:27
@rndmh3ro rndmh3ro requested a review from a team as a code owner April 19, 2024 08:27
in previous versions, the default was None, now it is an empty list. this would produce a diff
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also bump the documented required version of Icinga Director? I know the older versions still work, but they will have idempotency problems after this change.

@rndmh3ro rndmh3ro requested a review from schurzi April 19, 2024 12:55
@rndmh3ro rndmh3ro added bug Something isn't working patch labels Apr 19, 2024
@rndmh3ro rndmh3ro merged commit 9259ea2 into main Apr 19, 2024
59 checks passed
@rndmh3ro rndmh3ro deleted the user_grp_default branch April 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants