Skip to content

Commit

Permalink
Merge pull request #811 from telefonicaid/task/remove_unnecesarry_env…
Browse files Browse the repository at this point in the history
…_vars_from_dockerfile

Update Dockerfile: remove unnecessary env  vars
  • Loading branch information
fgalan authored Oct 31, 2024
2 parents 496a9e9 + 75da753 commit 9aa857e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGES_NEXT_RELEASE
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fix: deprecated mongo warnings about save and remove methods (#806)
- Fix: remove unnecessary env vars (PERSEO_MONGO_HOST and PERSEO_CORE_URL) from Dockerfile (#810)
- Upgrade express from 4.19.2 to 4.20.0
- Upgrade body-parser dep from 1.18.2 to 1.20.3
6 changes: 0 additions & 6 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ COPY --from=builder /opt/perseo-fe /opt/perseo-fe
RUN npm install [email protected] -g --no-package-lock --no-optional

USER node
ENV PERSEO_MONGO_HOST=mongodb
ENV PERSEO_CORE_URL=http://corehost:8080
ENV NODE_ENV=production

# Expose 9090 for HTTP PORT
Expand Down Expand Up @@ -181,8 +179,6 @@ COPY --from=anon-user /etc/passwd /etc/shadow /etc/group /etc/
WORKDIR /opt/perseo-fe

USER nobody
ENV PERSEO_MONGO_HOST=mongodb
ENV PERSEO_CORE_URL=http://corehost:8080
ENV NODE_ENV=production

# Expose 9090 for HTTP PORT
Expand Down Expand Up @@ -223,8 +219,6 @@ RUN \
rm -rf /var/lib/apt/lists/*

USER node
ENV PERSEO_MONGO_HOST=mongodb
ENV PERSEO_CORE_URL=http://corehost:8080
ENV NODE_ENV=production

# Expose 9090 for HTTP PORT
Expand Down

0 comments on commit 9aa857e

Please sign in to comment.