FIX address FIXME PR marks

telefonicaid · Feb 26, 2025 · dc8ed82 · dc8ed82
1 parent 5aefb49
commit dc8ed82
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 56 deletions.
diff --git a/...included-if-no-actual-update/previousvalue-metadata-not-included-if-no-actual-update.test b/...included-if-no-actual-update/previousvalue-metadata-not-included-if-no-actual-update.test
@@ -30,9 +30,6 @@ accumulatorStart --pretty-print
 
 --SHELL--
 
-# FIXME PR: previousValue field in subs is probably irrelevant. Remove it at the end.
-# FIXME PR: alterationType can be simplified to just entityUpdate
-
 #
 # 01. Create testing entity
 # 02. Create sub
@@ -76,9 +73,7 @@ payload='{
         "TimeInstant"
       ],
       "alterationTypes": [
-        "entityCreate",
-        "entityUpdate",
-        "entityDelete"
+        "entityUpdate"
       ],
       "notifyOnMetadataChange": true
     }
@@ -106,10 +101,6 @@ payload='{
         }
       }
     },
-    "metadata": [
-      "previousValue",
-      "*"
-    ],
     "covered": false
   }
 }'
@@ -172,7 +163,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36})
 ====================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Fiware-Servicepath: /
-Content-Length: 442
+Content-Length: 328
 User-Agent: orion/REGEX(\d+\.\d+\.\d+.*)
 Ngsiv2-Attrsformat: normalized
 Host: 127.0.0.1:REGEX(\d+)
@@ -184,12 +175,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36}); cbnotif=1
     "data": [
         {
             "TimeInstant": {
-                "metadata": {
-                    "previousValue": {
-                        "type": "DateTime",
-                        "value": "2025-02-10T16:41:00.000Z"
-                    }
-                },
+                "metadata": {},
                 "type": "DateTime",
                 "value": "2025-02-10T16:41:00.000Z"
             },
@@ -206,12 +192,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36}); cbnotif=1
                 "value": 0
             },
             "waterConsumption": {
-                "metadata": {
-                    "previousValue": {
-                        "type": "Number",
-                        "value": 20
-                    }
-                },
+                "metadata": {},
                 "type": "Number",
                 "value": 20
             }

diff --git a/...ayload/keyvalue-notification-format-not-working-in-custom-notifications-ngsi-payload.test b/...ayload/keyvalue-notification-format-not-working-in-custom-notifications-ngsi-payload.test
@@ -30,10 +30,6 @@ accumulatorStart --pretty-print
 
 --SHELL--
 
-# FIXME PR: this test is aligned with the wrong behaviour. It would "break" when we fix the issue
-# FIXME PR: previousValue field in subs is probably irrelevant. Remove it at the end.
-# FIXME PR: alterationType can be simplified to just entityUpdate
-
 #
 # 01. Create testing entity
 # 02. Create sub
@@ -77,9 +73,7 @@ payload='{
         "TimeInstant"
       ],
       "alterationTypes": [
-        "entityCreate",
-        "entityUpdate",
-        "entityDelete"
+        "entityUpdate"
       ],
       "notifyOnMetadataChange": true
     }
@@ -107,10 +101,6 @@ payload='{
         }
       }
     },
-    "metadata": [
-      "previousValue",
-      "*"
-    ],
     "covered": false
   }
 }'

diff --git a/...-payload/values-notification-format-not-working-in-custom-notifications-ngsi-payload.test b/...-payload/values-notification-format-not-working-in-custom-notifications-ngsi-payload.test
@@ -30,10 +30,6 @@ accumulatorStart --pretty-print
 
 --SHELL--
 
-# FIXME PR: this test is aligned with the wrong behaviour. It would "break" when we fix the issue
-# FIXME PR: previousValue field in subs is probably irrelevant. Remove it at the end.
-# FIXME PR: alterationType can be simplified to just entityUpdate
-
 #
 # 01. Create testing entity
 # 02. Create sub
@@ -77,9 +73,7 @@ payload='{
         "TimeInstant"
       ],
       "alterationTypes": [
-        "entityCreate",
-        "entityUpdate",
-        "entityDelete"
+        "entityUpdate"
       ],
       "notifyOnMetadataChange": true
     }
@@ -107,10 +101,6 @@ payload='{
         }
       }
     },
-    "metadata": [
-      "previousValue",
-      "*"
-    ],
     "covered": false
   }
 }'

diff --git a/...lues-notifications/jexl-expressions-not-working-in-simplifiedkeyvalues-notifications.test b/...lues-notifications/jexl-expressions-not-working-in-simplifiedkeyvalues-notifications.test
@@ -30,10 +30,6 @@ accumulatorStart --pretty-print
 
 --SHELL--
 
-# FIXME PR: this test is aligned with the wrong behaviour. It would "break" when we fix the issue
-# FIXME PR: previousValue field in subs is probably irrelevant. Remove it at the end.
-# FIXME PR: alterationType can be simplified to just entityUpdate
-
 #
 # 01. Create testing entity
 # 02. Create sub
@@ -77,9 +73,7 @@ payload='{
         "TimeInstant"
       ],
       "alterationTypes": [
-        "entityCreate",
-        "entityUpdate",
-        "entityDelete"
+        "entityUpdate"
       ],
       "notifyOnMetadataChange": true
     }
@@ -107,10 +101,6 @@ payload='{
         }
       }
     },
-    "metadata": [
-      "previousValue",
-      "*"
-    ],
     "covered": false
   }
 }'