Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v0.18.3 #14

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Release/v0.18.3 #14

merged 5 commits into from
Dec 4, 2024

Conversation

jharajeev55
Copy link
Contributor

No description provided.

@jharajeev55
Simplifying josn parser, so it should able to generate lua defination…
04cf64e 
…s for node commands , commenting most of code now, whre its havig lot of if else for commands which does not follow the normal pattern
@jharajeev55
removing no more required codes
f5b6fd6 
making tables to local so that it will not expose in node definitions
@jharajeev55
Moving static enums in json file
882f48e
@jharajeev55
updating version and changelog file
490da75
@jharajeev55 jharajeev55 requested a review from a team as a code owner December 4, 2024 14:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111
Total Passed Tests: 0111

esarver
esarver requested changes Dec 4, 2024
View reviewed changes
@jharajeev55
Node related changes (#13)
11e3e9c 
Making changes to support dynamically creating enums for configured
nodes

All the manually extracted enums has been moved to json file 

Note: trigger.model.load() and trigger.model.setblock() command still
having static enums , will be handled separately, because of its odd
command structure.
@jharajeev55 jharajeev55 requested a review from esarver December 4, 2024 15:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111
Total Passed Tests: 0111

@jharajeev55 jharajeev55 self-assigned this Dec 4, 2024
@jharajeev55 jharajeev55 merged commit f977f37 into main Dec 4, 2024
5 checks passed
@jharajeev55 jharajeev55 deleted the release/v0.18.3 branch December 4, 2024 15:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111
Total Passed Tests: 0111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esarver esarver esarver approved these changes

Assignees

@jharajeev55 jharajeev55

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jharajeev55 @esarver