Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node related changes #13

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Node related changes #13

merged 1 commit into from
Dec 4, 2024

Conversation

jharajeev55
Copy link
Contributor

@jharajeev55 jharajeev55 commented Dec 4, 2024 •
edited
Loading

Making changes to support dynamically creating enums for configured nodes

All the manually extracted enums has been moved to json file

Note: trigger.model.load() and trigger.model.setblock() command still having static enums , will be handled separately, because of its odd command structure.

@jharajeev55 jharajeev55 added the enhancement New feature or request label Dec 4, 2024
@jharajeev55 jharajeev55 self-assigned this Dec 4, 2024
@jharajeev55 jharajeev55 requested a review from a team as a code owner December 4, 2024 12:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111
Total Passed Tests: 0111

esarver
esarver requested changes Dec 4, 2024
View reviewed changes
@jharajeev55 jharajeev55 requested a review from esarver December 4, 2024 14:53
@jharajeev55 jharajeev55 changed the base branch from main to release/v0.18.3 December 4, 2024 14:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111
Total Passed Tests: 0111

@jharajeev55 jharajeev55 merged commit 11e3e9c into release/v0.18.3 Dec 4, 2024
5 checks passed
@jharajeev55 jharajeev55 deleted the node_related_changes branch December 4, 2024 14:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

JSON File Check Results

Test failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2450/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2460/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2461/\nTest passed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2470/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B-PULSE/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2601B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2602B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2604B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2611B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2612B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2614B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2634B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2635B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2636B/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2651A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/2657A/\nTest failed for subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/DMM7510/\nNo JSON file found in subfolder: /home/runner/work/tsp-toolkit-webhelp-to-json/tsp-toolkit-webhelp-to-json/testResults/tsp-lua-5.0/\n
Total Failed Tests: 011111111111111
Total Passed Tests: 0111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esarver esarver esarver approved these changes

@Shreya-GT Shreya-GT Awaiting requested review from Shreya-GT

@pavannarayana pavannarayana Awaiting requested review from pavannarayana

Assignees

@jharajeev55 jharajeev55

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jharajeev55 @esarver