-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packaging workflows to correctly gate on the repo name. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix#182) Signed-off-by: Nicholas Felt <[email protected]>
…h testing jobs. Signed-off-by: Nicholas Felt <[email protected]>
Signed-off-by: Nicholas Felt <[email protected]>
Signed-off-by: Nicholas Felt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 3804 3804
Branches 643 643
=========================================
Hits 3804 3804 ☔ View full report in Codecov by Sentry. |
qthompso
approved these changes
Apr 3, 2024
ldantek
approved these changes
Apr 3, 2024
Test Results (ubuntu)
|
Test Results (macos)
|
Test Results (windows)
|
nfelt14
added a commit
to nfelt14/tm_devices
that referenced
this pull request
May 2, 2024
…x#185) * ci: Update package-release.yml and package-testpypi.yml to use new method of checking repo name. --------- Signed-off-by: Nicholas Felt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There was a bug introduced into the packaging workflows that prevented them from running. This bug has been fixed, and now the jobs gate on the repo name by checking the outputs of a previously run job.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.