-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile for Catlin #692
Conversation
I wonder if we want to add |
either way to not adding it i am fine... i just followed what we had in other tekton repository. |
@chmouel is this the kind of thing we'd want to have in our Pipelines and Tasks? i'm wondering why we'd want to use a makefile for this vs having using a go build Task |
@bobcatfish it's only there to be able run the test or linter easily when developing on the local developer machine, I don't think we have a solution for that |
ah okay, interesting, thanks @chmouel i hope one day we'll make it so we don't have to have a different set of scripts and automation for local development (tektoncd/community#145 🤞 ) |
38f9b63
to
0d45884
Compare
/retest |
/kind feature |
/retest |
/test .* |
I think the yamllint job has some issues i have logged an issue here : |
0d45884
to
f6896bc
Compare
Add vendor directory too.
f6896bc
to
866faa3
Compare
/test plumbing-yamllint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Add a Makefile for catlin with a few common targets.
Add the vendor directory too.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.