Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile for Catlin #692

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jan 22, 2021

Changes

Add a Makefile for catlin with a few common targets.
Add the vendor directory too.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 22, 2021
@vdemeester
Copy link
Member

I wonder if we want to add vendor though. So far we didn't rely on vendor for any go tooling in that repository to not have a huge content (like multiple vendor directory for each go tool). @chmouel Could we split the Makefile from the vendor part to get one in quickly and discuss the other ?

@chmouel
Copy link
Member Author

chmouel commented Jan 22, 2021

either way to not adding it i am fine... i just followed what we had in other tekton repository.

@bobcatfish
Copy link
Contributor

@chmouel is this the kind of thing we'd want to have in our Pipelines and Tasks? i'm wondering why we'd want to use a makefile for this vs having using a go build Task

@chmouel
Copy link
Member Author

chmouel commented Jan 25, 2021

@bobcatfish it's only there to be able run the test or linter easily when developing on the local developer machine, I don't think we have a solution for that

@bobcatfish
Copy link
Contributor

ah okay, interesting, thanks @chmouel

i hope one day we'll make it so we don't have to have a different set of scripts and automation for local development (tektoncd/community#145 🤞 )

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 26, 2021
@chmouel
Copy link
Member Author

chmouel commented Jan 26, 2021

/retest

@chmouel
Copy link
Member Author

chmouel commented Jan 26, 2021

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2021
@chmouel
Copy link
Member Author

chmouel commented Jan 27, 2021

/retest

@vdemeester
Copy link
Member

/test .*

@chmouel
Copy link
Member Author

chmouel commented Jan 27, 2021

I think the yamllint job has some issues i have logged an issue here :

#698

Base automatically changed from master to main February 4, 2021 09:16
Add vendor directory too.
@afrittoli
Copy link
Member

/test plumbing-yamllint

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit fa0bc9f into tektoncd:main Apr 14, 2021
@chmouel chmouel deleted the catlin-add-makefile branch April 14, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants