Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tekton/images: remove openssh-server… #2064

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

vdemeester
Copy link
Member

Changes

I don't think it is used anywhere, so let's not have to maintain it.

Signed-off-by: Vincent Demeester [email protected]

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 4, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2024
I don't think it is used anywhere, so let's not have to maintain it.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the remove-openssh-server-image branch from d64f6be to 7d0977e Compare July 4, 2024 07:33
@vdemeester
Copy link
Member Author

@afrittoli I think the image-build failure is "kind-of" expected 😅

Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2024
@vdemeester
Copy link
Member Author

Related to #1839. @afrittoli I think with the way the ci is currently setup, we can't get the plumbing-image-build green, do we want to "force" merge, or ?

afrittoli added a commit to afrittoli/plumbing that referenced this pull request Jul 31, 2024
When a dockerfile is removed, the build CI job fails today as it
see the file in the list of modified ones, but cannot locate it
to run the test.

This still logs the missing file condition, but do not fail, so
that we may pass CI on PRs that delete a dockerfile, like:
- tektoncd#2065
- tektoncd#2064

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli mentioned this pull request Jul 31, 2024
2 tasks
@afrittoli
Copy link
Member

/test plumbing-image-build

@tekton-robot
Copy link
Contributor

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-image-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

tekton-robot commented Jul 31, 2024

The following Tekton test failed:

Test name Commit Details Required Rerun command
plumbing-unit-tests d64f6be link true /test plumbing-unit-tests

@afrittoli
Copy link
Member

/test plumbing-image-build

@tekton-robot
Copy link
Contributor

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-image-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit fecc4d4 into tektoncd:main Jul 31, 2024
6 checks passed
@vdemeester vdemeester deleted the remove-openssh-server-image branch July 31, 2024 13:13
tekton-robot pushed a commit that referenced this pull request Jul 31, 2024
When a dockerfile is removed, the build CI job fails today as it
see the file in the list of modified ones, but cannot locate it
to run the test.

This still logs the missing file condition, but do not fail, so
that we may pass CI on PRs that delete a dockerfile, like:
- #2065
- #2064

Signed-off-by: Andrea Frittoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants