Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix python 3.13 deprecation #1077

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: fix python 3.13 deprecation #1077

merged 1 commit into from
Sep 12, 2024

Conversation

tlambert03
Copy link
Contributor

📒 Description

deals with the deprecation error added in python 3.13 to the private usage of typing._eval_type when called without type_params

https://github.com/python/cpython/blob/3bd942f106aa36c261a2d90104c027026b2a8fb6/Lib/typing.py#L474

Resolves #1076

🛫 Checklist

Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8f266d5) to head (79ae453).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1077   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9259      9263    +4     
  Branches      2183      2184    +1     
=========================================
+ Hits          9259      9263    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@tefra tefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tefra tefra merged commit 9a0e785 into tefra:main Sep 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type evaluation needs to be updated for python 3.13
2 participants