feat: Use the event writer to build element trees #1032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
The first impl was a disaster, because I thought the treebuilders from lxml and native python, could deal with sax events out of the box, but that wasn't the case. I had to reuse the EventContent handler we use for normal xml serialization in order to get a consistent output.
Unfortunately because of limitations with the python's ElementTree with namespaces and prefixes, the TreeSerializer only works with lxml.
Resolves #1028
🔗 What I've Done
💬 Comments
🛫 Checklist