Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow short closed elements #1027

Closed
wants to merge 1 commit into from
Closed

Conversation

tefra
Copy link
Owner

@tefra tefra commented Apr 28, 2024

📒 Description

Resolves #xxxx

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@tefra tefra force-pushed the fix-short-closed-elements branch from 2872c93 to 2a9eb1c Compare April 28, 2024 06:32
Copy link

sonarcloud bot commented Apr 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.97%. Comparing base (eab6bb7) to head (2a9eb1c).

Files Patch % Lines
...sdata/formats/dataclass/serializers/tree/mixins.py 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1027      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files          117      117              
  Lines         9272     9278       +6     
  Branches      2194     2196       +2     
===========================================
+ Hits          9272     9276       +4     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra closed this Apr 28, 2024
@tefra tefra deleted the fix-short-closed-elements branch May 7, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant