Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to ignore duration in tests #3569

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Allow to ignore duration in tests #3569

wants to merge 5 commits into from

Conversation

lukaszachy
Copy link
Collaborator

@lukaszachy lukaszachy commented Mar 4, 2025 •
edited
Loading

There are other ways to adjust this value, but sometimes it is just easier to just let test run.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • include a release note

@lukaszachy
Copy link
Collaborator Author

Envar TMT_PLUGIN_EXECUTE_IGNORE_DURATION=1 is the right way to specify this via envars, right? But it doesn't seem to work for me :/

@lukaszachy
Copy link
Collaborator Author

Envar TMT_PLUGIN_EXECUTE_IGNORE_DURATION=1 is the right way to specify this via envars, right? But it doesn't seem to work for me :/

Ah, because I didn't have execute -h tmt on command line, so plugin variable didn't work for a default command....
I guess this is something we have to fix at least for this use case, right?

@lukaszachy lukaszachy added the status | discuss Needs more discussion before closing label Mar 4, 2025
@happz happz removed the status | discuss Needs more discussion before closing label Mar 4, 2025
@happz happz added this to the 1.44 milestone Mar 4, 2025
@happz happz added step | execute Stuff related to the execute step priority | must high priority, must be included in the next release labels Mar 4, 2025
@lukaszachy lukaszachy added the ci | full test Pull request is ready for the full test execution label Mar 4, 2025
@lukaszachy lukaszachy marked this pull request as ready for review March 4, 2025 15:24
@lukaszachy
Copy link
Collaborator Author

envvar doesn't win over CLI/plan data to keep this consistent with reporportal/polarion plugins.

happz
happz reviewed Mar 5, 2025
View reviewed changes
happz
happz reviewed Mar 5, 2025
View reviewed changes
happz
happz reviewed Mar 5, 2025
View reviewed changes
martinhoyer
martinhoyer reviewed Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing useful to add to the option/key, envvar discussion. Maybe just a question about whether there is something related being cooked in @happz's stash that could be merged before this to avoid later changes ;)

@lukaszachy lukaszachy requested review from martinhoyer and happz March 7, 2025 08:48
psss
psss requested changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Added a few suggestions.

@lukaszachy lukaszachy requested a review from psss March 11, 2025 09:55
@psss psss force-pushed the ignore-duration branch from b009976 to d0f9741 Compare March 11, 2025 12:42
@psss
Copy link
Collaborator

psss commented Mar 11, 2025

Rebased, 3 acks, should be ready for merge.

@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Mar 11, 2025
lukaszachy and others added 5 commits March 11, 2025 17:31
@lukaszachy
Allow to ignore duration in tests
4a20eb0 
There are other ways to adjust this value, but sometimes
it is just easier to just let test run as long as they need.
@lukaszachy
squash: addressing review
adce94b
@lukaszachy
squash: fix man docs
b1c94e1
@lukaszachy
squash: remove alias
e3de9eb 
I used it to run against local pipx install and forgot to remove :/
@lukaszachy @psss
squash: apply suggestions from code review
ca9fb17 
Co-authored-by: Petr Šplíchal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | execute Stuff related to the execute step
Projects
None yet
Milestone
1.44
Development

Successfully merging this pull request may close these issues.
5 participants
@lukaszachy @psss @happz @KwisatzHaderach @martinhoyer