Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reportportal schema for traceback and log size limits #3477

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix reportportal schema for traceback and log size limits #3477

merged 1 commit into from
Jan 28, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 22, 2025

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working code | schema Schema used for validating config files code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. plugin | reportportal The reportportal report plugin labels Jan 22, 2025
@happz happz added this to the 1.42 milestone Jan 22, 2025
@thrix
Copy link
Collaborator

thrix commented Jan 26, 2025

@happz can you share more light why size limits should not be an integer?

@happz
Copy link
Collaborator Author

happz commented Jan 26, 2025

@happz can you share more light why size limits should not be an integer?

User may also provide a string, a number with a unit: --traceback-limit=1MB. The default value itself is not an integer, 50 kB.

@happz happz force-pushed the fix-reportportal-limits-schema branch from a010dba to d108d6f Compare January 27, 2025 10:02
thrix
thrix approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss changed the title Fix reportportal schema for traceback and log size limits Fix reportportal schema for traceback and log size limits Jan 27, 2025
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 27, 2025
@happz happz force-pushed the fix-reportportal-limits-schema branch from d108d6f to 7c9fcbc Compare January 28, 2025 09:20
@thrix thrix added the ci | full test Pull request is ready for the full test execution label Jan 28, 2025
@thrix
Copy link
Collaborator

thrix commented Jan 28, 2025

/packit retest-failed

@thrix thrix enabled auto-merge (squash) January 28, 2025 14:07
@thrix thrix force-pushed the fix-reportportal-limits-schema branch from 7c9fcbc to 7f1b27b Compare January 28, 2025 14:09
@thrix thrix merged commit 108b98d into main Jan 28, 2025
20 checks passed
@thrix thrix deleted the fix-reportportal-limits-schema branch January 28, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | schema Schema used for validating config files plugin | reportportal The reportportal report plugin status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @thrix @KwisatzHaderach @psss