Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reboot functionality for artemis plugin #3473

Open
wants to merge 1 commit into
base: cleanup-guest-reboot-implementations
Choose a base branch
from
Open

Implement reboot functionality for artemis plugin #3473

wants to merge 1 commit into from

Conversation

ukulekek
Copy link
Collaborator

@ukulekek ukulekek commented Jan 17, 2025 •
edited
Loading

The PR adds the missing reboot function to the GuestArtemis class. It supports both soft and hard reboots and utilises the perform_reboot parent class function.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@ukulekek ukulekek force-pushed the artemis-reboot branch 5 times, most recently from c840706 to 58a83ce Compare January 21, 2025 13:23
@ukulekek ukulekek changed the title implement reboot for artemis plugin Implement reboot functionality for artemis plugin Jan 21, 2025
@ukulekek ukulekek marked this pull request as ready for review January 21, 2025 13:33
@ukulekek ukulekek added step | provision Stuff related to the provision step command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command plugin | artemis Related to Artemis provision plugin labels Jan 21, 2025
@happz happz force-pushed the cleanup-guest-reboot-implementations branch from c314f9b to 6087ca4 Compare January 21, 2025 20:57
@happz happz requested a review from frantisekz as a code owner January 21, 2025 20:57
@happz happz added this to the 1.43 milestone Jan 24, 2025
@happz happz force-pushed the cleanup-guest-reboot-implementations branch from 6087ca4 to 7b7ab65 Compare January 28, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz Awaiting requested review from happz happz is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

@frantisekz frantisekz Awaiting requested review from frantisekz

Assignees
No one assigned
Labels
command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command plugin | artemis Related to Artemis provision plugin step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.
2 participants
@ukulekek @happz