When saving a traceback, shorten very large locals #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
happz
force-pushed
the
trim-locals-in-tracebacks
branch
from
1134196 to
b62b592
Compare
skycastlelily
approved these changes
Jan 15, 2025
lukaszachy
reviewed
Jan 15, 2025
| #: Render also call stack for exception and each of its causes, | ||
| #: plus all local variables in each frame, trimmed to first 1024 | ||
| #: characters of their values. | ||
| LOCALS = '2' |
There was a problem hiding this comment.
Why '2' and not 'locals' ? It might be more descriptive, or?
There was a problem hiding this comment.
It may, I wanted to have a breathing space for the future, in case we find some new verbosity levels between full and the rest. full is easy, it's everything that can be shown, but finding names for verbose-but-not-so-verbose levels is harder. If there's a more verbose level after levels, how would it be called, and how would a user tell which of those names is the more verbose one? 2 vs 3 would be easy.
therazix
approved these changes
Jan 16, 2025
happz
force-pushed
the
trim-locals-in-tracebacks
branch
from
b62b592 to
5e7de3f
Compare
thrix
added
ci | full test
|
/packit test |
A traceback in `log.txt` can be very large, especially when saving locals like a huge set of result or junit XML. Adding a level of traceback verbosity, `locals`, which will log locals, but shorten the very long ones. `full` will keep showing everything on terminal.
happz
force-pushed
the
trim-locals-in-tracebacks
branch
from
5e7de3f to
769d50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A traceback in
log.txtcan be very large, especially when saving locals like a huge set of result or junit XML. Adding a level of traceback verbosity,locals, which will log locals, but shorten the very long ones.fullwill keep showing everything on terminal.Pull Request Checklist