-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate the execute
step documentation
#3415
Conversation
c725084
to
d8358ea
Compare
d8358ea
to
31551a7
Compare
05ad976
to
2382ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But shouldn't we keep the references in the text, just as they are in the specification? Or is there a reason for leaving them out?
Thanks for the heads-up, I don't know why I thought the refs won't work 😅, adding them back |
2382ef9
to
46f809d
Compare
execute
step documentation
1b9ce42
to
299a4ce
Compare
PR updated with information removed from the specs, could this be reviewed again? Thanks ! |
The documentation about the execute is duplicated between the specifications and the plugins sections. Lets put all the info in the plugins section. Signed-off-by: mcasquer <[email protected]>
Signed-off-by: mcasquer <[email protected]>
…pgrade Signed-off-by: mcasquer <[email protected]>
Signed-off-by: mcasquer <[email protected]>
Signed-off-by: mcasquer <[email protected]>
Signed-off-by: mcasquer <[email protected]>
Signed-off-by: mcasquer <[email protected]>
Signed-off-by: mcasquer <[email protected]>
299a4ce
to
ae43a5f
Compare
The documentation about the execute is duplicated between
the specifications and the plugins sections. Lets put all
the info in the plugins section.
Pull Request Checklist