Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace open+read/write with pathlib's read/write_text/bytes #3263

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Replace open+read/write with pathlib's read/write_text/bytes #3263

merged 6 commits into from
Oct 11, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Oct 5, 2024

Pull Request Checklist

  • implement the feature

@happz happz added code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Oct 5, 2024
@happz happz added this to the 1.38 milestone Oct 5, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 7, 2024
@happz happz marked this pull request as ready for review October 7, 2024 14:14
thrix
thrix reviewed Oct 8, 2024
View reviewed changes
thrix
thrix reviewed Oct 8, 2024
View reviewed changes
@happz happz force-pushed the drop-open-fot-read-write-text-bytes branch from 9e9e0be to 187f79d Compare October 8, 2024 14:28
@thrix thrix self-requested a review October 10, 2024 12:05
thrix
thrix approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Oct 10, 2024
@happz happz force-pushed the drop-open-fot-read-write-text-bytes branch from 9068dc4 to 2536151 Compare October 10, 2024 12:12
psss
psss requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one nitpick?

@psss psss force-pushed the drop-open-fot-read-write-text-bytes branch from 90500c7 to 532e5a6 Compare October 10, 2024 19:58
@happz
Copy link
Collaborator Author

happz commented Oct 11, 2024

Unrelated failures, merging.

@happz happz merged commit b871f30 into main Oct 11, 2024
22 of 23 checks passed
@happz happz deleted the drop-open-fot-read-write-text-bytes branch October 11, 2024 06:31
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Replace open+read/write with pathlib's read/write_text/bytes (teemtee…
afb44ee 
…#3263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinhoyer martinhoyer martinhoyer left review comments

@thrix thrix thrix approved these changes

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

@frantisekz frantisekz Awaiting requested review from frantisekz frantisekz is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.
5 participants
@happz @thrix @psss @martinhoyer @therazix