Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test result key should be implemented as enum, not a string #3253

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Oct 1, 2024

This is a leftover from transitioning to enums in the past.

Pull Request Checklist

  • implement the feature

@happz happz added code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Oct 1, 2024
@happz happz added this to the 1.38 milestone Oct 1, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@psss psss force-pushed the test-result-shall-be-enum branch from 3bbff0c to 50563c7 Compare October 3, 2024 07:48
@psss psss added ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. labels Oct 3, 2024
@psss
Copy link
Collaborator

psss commented Oct 3, 2024

Seems we have a little regression:

:: [ 08:12:17 ] :: [  BEGIN   ] :: Running 'tmt tests show mini'
/tests/mini
                    test ./test.sh
                    path /tests
               framework shell
                  manual false
                     tty false
                duration 5m
                 enabled true
                  result ResultInterpret.RESPECT
       restart_max_count 1
     restart_with_reboot false

:: [ 08:12:18 ] :: [   FAIL   ] :: File '/var/tmp/rlRun_LOG.H4A4Jrdi' should contain 'result respect' 

@happz
Copy link
Collaborator Author

happz commented Oct 3, 2024

Seems we have a little regression:

:: [ 08:12:17 ] :: [  BEGIN   ] :: Running 'tmt tests show mini'
/tests/mini
                    test ./test.sh
                    path /tests
               framework shell
                  manual false
                     tty false
                duration 5m
                 enabled true
                  result ResultInterpret.RESPECT
       restart_max_count 1
     restart_with_reboot false

:: [ 08:12:18 ] :: [   FAIL   ] :: File '/var/tmp/rlRun_LOG.H4A4Jrdi' should contain 'result respect' 

Addressed in bad555b

@psss
Copy link
Collaborator

psss commented Oct 4, 2024

Failing test is an unrelated Unrecognized package manager. error, merging.

@psss psss merged commit 14d60dc into main Oct 4, 2024
22 of 23 checks passed
@psss psss deleted the test-result-shall-be-enum branch October 4, 2024 07:21
@psss psss self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants