-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new examples to overwrite the inheritance problem #3178
Conversation
The same idea needs to be implemented for the |
I was thinking a bit more about the possible solutions, here's my brainstorm:
Last one would probably break some other @mcasquer, could you add a simple, few-lines example, for each step? This would override the inherited general one. Anyway, we don't want to spend much time on this as the long-term plan is to deduplicate the step plugin docs by moving the to the plugin code. |
d73f9d6
to
998292d
Compare
@psss added an empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, just two comments.
b7178a1
to
7af3095
Compare
7af3095
to
e6a1fa0
Compare
The examples code block from spec/plans/main.fmf is being wrongly inherited by some of the specs. Adding new examples blocks to avoid this problem. Signed-off-by: mcasquer <[email protected]>
e6a1fa0
to
bbd45cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Looks good, I've only adjusted the example
indentation.
Spec change only, merging. |
The examples code block from spec/plans/main.fmf
is being wrongly inherited by some of the specs. Adding
new examples blocks to avoid this problem.
Pull Request Checklist