Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation of fmf id URL, it must be cloneable first #2957

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix validation of fmf id URL, it must be cloneable first #2957

merged 1 commit into from
May 29, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented May 23, 2024

Pull Request Checklist

  • implement the feature

@happz happz added this to the 1.34 milestone May 23, 2024
@happz happz added bug Something isn't working code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. command | lint tmt lint command labels May 27, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label May 27, 2024
@lukaszachy lukaszachy added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label May 28, 2024
@happz happz force-pushed the fix-fmf-id-validation-cloneable-url branch from 6a998ac to 270f726 Compare May 28, 2024 13:25
@happz happz requested a review from martinhoyer as a code owner May 28, 2024 13:25
@happz happz changed the base branch from fix-dnf-debuginfo-skip-option to main May 28, 2024 13:25
@happz happz enabled auto-merge (squash) May 28, 2024 13:26
@happz
Copy link
Collaborator Author

happz commented May 29, 2024

Unrelated virtual failure, merging.

@happz happz disabled auto-merge May 29, 2024 07:04
@happz happz merged commit bde322d into main May 29, 2024
16 of 17 checks passed
@happz happz deleted the fix-fmf-id-validation-cloneable-url branch May 29, 2024 07:04
happz added a commit that referenced this pull request Jun 2, 2024
@happz
Fix validation of fmf id URL, it must be cloneable first (#2957)
ac1d1cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

Assignees
No one assigned
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. command | lint tmt lint command status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @lukaszachy @therazix