Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cpu.model-name hardware requirement for mrack #2921

Merged
merged 2 commits into from
May 23, 2024
Merged

Support cpu.model-name hardware requirement for mrack #2921

merged 2 commits into from
May 23, 2024

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented May 9, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added this to the 1.34 milestone May 9, 2024
@happz happz added step | provision Stuff related to the provision step area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin labels May 9, 2024
@happz
Copy link
Collaborator

happz commented May 21, 2024

@skycastlelily please, resolve the conflict & rebase on top of main.

@skycastlelily
Copy link
Collaborator Author

skycastlelily commented May 22, 2024 via email

@happz happz added the ci | full test Pull request is ready for the full test execution label May 22, 2024
@happz
Copy link
Collaborator

happz commented May 22, 2024

/packit test

@happz
Copy link
Collaborator

happz commented May 22, 2024

/packit build-missing

@happz
Copy link
Collaborator

happz commented May 22, 2024

/packit build

@happz
Copy link
Collaborator

happz commented May 23, 2024

Unrelated failures in provision check, looks like a crappy infrastructure ruining virtual tests across the board. Merging.

@happz happz merged commit 15cc8eb into main May 23, 2024
18 of 19 checks passed
@happz happz deleted the model-name branch May 23, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@therazix therazix therazix approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual dav-pascual is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution plugin | mrack The beaker provision plugin step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
3 participants
@skycastlelily @happz @therazix