Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable to print color if --no-color is specified #2816

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

idorax
Copy link
Contributor

@idorax idorax commented Apr 3, 2024

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

Fixes: #2759

@idorax idorax marked this pull request as draft April 3, 2024 12:38
tmt/utils.py Outdated Show resolved Hide resolved
@idorax idorax force-pushed the dev-huanli-2759-20240326 branch 2 times, most recently from d87b8e2 to f307927 Compare April 11, 2024 12:25
idorax added a commit that referenced this pull request Apr 11, 2024
The solution from Milos is better than mine. For details, please refer to:
    #2816 (comment)

Signed-off-by: Vector Li <[email protected]>
@idorax idorax marked this pull request as ready for review April 11, 2024 13:04
@idorax idorax marked this pull request as draft May 29, 2024 14:59
@idorax idorax marked this pull request as ready for review June 6, 2024 11:44
@idorax
Copy link
Contributor Author

idorax commented Jun 7, 2024

Hi @happz, please help complete the remaining work of this PR as I no longer have the permission to update it, thanks very much!

huanli@FOO:~/dev/2759/dev$ git remote -v
origin	[email protected]:teemtee/tmt.git (fetch)
origin	[email protected]:teemtee/tmt.git (push)

huanli@FOO:~/dev/2759/dev$ git branch -a | grep huanli
* dev-huanli-2759-20240326
  remotes/origin/dev-huanli-1062-20240320-fips
  remotes/origin/dev-huanli-1918-20230316-login-t
  remotes/origin/dev-huanli-2759-20240326

huanli@FOO:~/dev/2759/dev$ git push -f
ERROR: Permission to teemtee/tmt.git denied to idorax.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

And the patch is synced with the latest main branch, please refer to 51f962b .

@happz happz added this to the 1.35 milestone Jun 17, 2024
@happz
Copy link
Collaborator

happz commented Jun 18, 2024

Hi @happz, please help complete the remaining work of this PR as I no longer have the permission to update it, thanks very much!

That's weird, I don't recall any change that would suddenly prevent you from pushing to branches like you used to. Could it be just a temporary glitch? "fatal: Could not read from remote repository." suggests it might have been a network issue or Github outage or something like that. Have you tried pushing to teemtee/tmt since then?

I can definitely finish the PR if needed, but I'd prefer getting your workflow fixed so you could contribute even more :)

@martinhoyer
Copy link
Collaborator

Hi @happz, please help complete the remaining work of this PR as I no longer have the permission to update it, thanks very much!

That's weird, I don't recall any change that would suddenly prevent you from pushing to branches like you used to. Could it be just a temporary glitch? "fatal: Could not read from remote repository." suggests it might have been a network issue or Github outage or something like that. Have you tried pushing to teemtee/tmt since then?

I can definitely finish the PR if needed, but I'd prefer getting your workflow fixed so you could contribute even more :)

hmm, I don't see @idorax in https://github.com/orgs/teemtee/people. Maybe it's best to just use a fork going forward.

@psss psss changed the title Disable to print color if --no-color is specified Disable to print color if --no-color is specified Jun 25, 2024
@idorax
Copy link
Contributor Author

idorax commented Jun 28, 2024

hmm, I don't see @idorax in https://github.com/orgs/teemtee/people. Maybe it's best to just use a fork going forward.

Hi @martinhoyer, thank you very much for checking it. I'm not in the group, when I open link https://github.com/orgs/teemtee/people, such a message in the following is seen:

This organization has no public members. 

@happz, please help to complete the remaining work of this PR, thank you very much!

@martinhoyer
Copy link
Collaborator

@idorax You can use fork branches :)

happz pushed a commit that referenced this pull request Jul 9, 2024
The solution from Milos is better than mine. For details, please refer to:
    #2816 (comment)

Signed-off-by: Vector Li <[email protected]>
@happz happz force-pushed the dev-huanli-2759-20240326 branch from d51965a to 247400d Compare July 9, 2024 08:27
@happz happz added the code | logging Changes related to debug logging label Jul 9, 2024
@idorax
Copy link
Contributor Author

idorax commented Jul 21, 2024

@happz, thanks very much for updating the test!

martinhoyer pushed a commit that referenced this pull request Aug 1, 2024
The solution from Milos is better than mine. For details, please refer to:
    #2816 (comment)

Signed-off-by: Vector Li <[email protected]>
@martinhoyer
Copy link
Collaborator

/packit build

@thrix thrix added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 1, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Aug 1, 2024
happz pushed a commit that referenced this pull request Aug 1, 2024
The solution from Milos is better than mine. For details, please refer to:
    #2816 (comment)

Signed-off-by: Vector Li <[email protected]>
@happz
Copy link
Collaborator

happz commented Aug 1, 2024

/packit build

happz pushed a commit that referenced this pull request Aug 2, 2024
The solution from Milos is better than mine. For details, please refer to:
    #2816 (comment)

Signed-off-by: Vector Li <[email protected]>
@happz
Copy link
Collaborator

happz commented Aug 2, 2024

/packit build

@happz
Copy link
Collaborator

happz commented Aug 5, 2024

Pushing out to 1.36, there seems to be failing tests as a side-effect of my changes.

@happz happz modified the milestones: 1.35, 1.36 Aug 5, 2024
@happz happz removed the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 6, 2024
@happz
Copy link
Collaborator

happz commented Aug 6, 2024

/packit build

@happz happz merged commit 6f9636f into main Aug 6, 2024
20 checks passed
@happz happz deleted the dev-huanli-2759-20240326 branch August 6, 2024 13:48
@happz happz modified the milestones: 1.36, 1.35 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | logging Changes related to debug logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmt --no-color prints color on discover failure
6 participants