Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tarballs and generated man page #2571

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Ignore tarballs and generated man page #2571

merged 1 commit into from
Jan 9, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 15, 2023

Prevent comitting tests/full/repo_copy.tgz and man page generated from the overview.rst.

@psss psss added the process label Dec 15, 2023
@psss psss added this to the 1.31 milestone Dec 15, 2023
@psss
Copy link
Collaborator Author

psss commented Dec 15, 2023

Interesting, adding tmt.1 to .gitignore causes the man page to be excluded from the tarball:

+ install -pm 644 tmt.1 /builddir/build/BUILDROOT/tmt-1.31.dev888-1.20231215085100339428.pr2571.2.g66d8162b.fc40.x86_64/usr/share/man/man1
install: cannot stat 'tmt.1': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.3htXMm (%install)

But I see it explicitly listed in the included files:

tmt/pyproject.toml

Lines 93 to 104 in 777bee7

[tool.hatch.build.targets.sdist]
include = [
"/tmt",
"/LICENSE",
"/examples",
"/README.rst",
"/tests",
"/tmt.spec",
"/tmt.1",
"/completions",
"/.fmf",
]

@martinhoyer, does .gitignore override tool.hatch.build.targets.sdist setting? Or am I missing anything else?

@martinhoyer
Copy link
Collaborator

martinhoyer commented Dec 15, 2023

@martinhoyer, does .gitignore override tool.hatch.build.targets.sdist setting? Or am I missing anything else?

Hatchling does take .gitignore into account by default. See https://hatch.pypa.io/latest/config/build/#file-selection

@martinhoyer
Copy link
Collaborator

Adding man page to [tool.hatch.build.targets.sdist] as is documented at https://hatch.pypa.io/latest/config/build/#artifacts

@psss
Copy link
Collaborator Author

psss commented Jan 9, 2024

Adding man page to [tool.hatch.build.targets.sdist] as is documented at https://hatch.pypa.io/latest/config/build/#artifacts

Nice! Thanks for fixing this.

@psss psss self-assigned this Jan 9, 2024
Prevent comitting `tests/full/repo_copy.tgz` and man page
generated from the `overview.rst`.
@psss
Copy link
Collaborator Author

psss commented Jan 9, 2024

/packit test --identifier full

@psss psss merged commit d1df3bd into main Jan 9, 2024
18 checks passed
@psss psss deleted the update-git-ignore branch January 9, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants