Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move code-related pages under new code directory #2545

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Move code-related pages under new code directory #2545

merged 1 commit into from
Jan 4, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Dec 5, 2023

Namely, plugins.rst becomes code/plugins.rst, which vacates a place for documentation of actual plugins to live in plugins/.

Pull Request Checklist

  • implement the feature

@happz happz added documentation Improvements or additions to documentation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Dec 5, 2023
@happz happz added this to the 1.31 milestone Dec 5, 2023
@happz happz force-pushed the docs-plugins-rename branch 3 times, most recently from f564b1d to 025dc74 Compare December 15, 2023 15:48
@happz happz mentioned this pull request Dec 15, 2023
Open
@happz happz force-pushed the docs-plugins-rename branch 2 times, most recently from 49b9ddb to 722af16 Compare January 3, 2024 22:16
@happz happz added the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label Jan 3, 2024
psss
psss approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one typo, fixed in 6575508.

@happz @psss
Move code-related pages under new code directory
a6bfc52 
Namely, `plugins.rst` becomes `code/plugins.rst`, which vacates a place
for documentation of actual plugins to live in `plugins/`.
@psss psss self-assigned this Jan 4, 2024
@psss psss changed the title Move code-related pages under new code directory Move code-related pages under new code directory Jan 4, 2024
@psss
Copy link
Collaborator

psss commented Jan 4, 2024

/packit test --identifier full

@happz happz merged commit 0c3824a into main Jan 4, 2024
18 checks passed
@happz happz deleted the docs-plugins-rename branch January 4, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @lukaszachy