Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tmt try for interactive sessions #2443

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Implement tmt try for interactive sessions #2443

merged 1 commit into from
Dec 5, 2023

Conversation

psss
Copy link
Collaborator

@psss psss commented Oct 30, 2023 •
edited
Loading

Basic functionality for the new tmt try command to be used for test development in an interactive session. Supports running tests from the current working directory as well as quick experimenting with selected distro image and provision method. Simple user plan config is included as well.

Fix #606 and https://issues.redhat.com/browse/TT-245

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • update the specification
  • mention the version
  • include a release note

@psss psss marked this pull request as draft October 30, 2023 21:52
@psss psss added command | try tmt try command enhancement labels Oct 30, 2023
@psss psss added this to the 1.30 milestone Oct 31, 2023
happz
happz reviewed Oct 31, 2023
View reviewed changes
tmt/base.py Outdated Show resolved Hide resolved
happz
happz reviewed Oct 31, 2023
View reviewed changes
tmt/base.py Show resolved Hide resolved
happz
happz reviewed Oct 31, 2023
View reviewed changes
tmt/cli.py Outdated Show resolved Hide resolved
happz
happz reviewed Oct 31, 2023
View reviewed changes
tmt/utils.py Outdated Show resolved Hide resolved
happz
happz reviewed Oct 31, 2023
View reviewed changes
tmt/steps/__init__.py Outdated Show resolved Hide resolved
happz
happz reviewed Oct 31, 2023
View reviewed changes
tmt/queue.py Outdated Show resolved Hide resolved
@lukaszachy
Copy link
Collaborator

What should happen after aborted menu (eg. ctrl+d or ctrl+c)? Currently provisioned machine keeps running.
If we keep 'quit' option I'd suggest aborting menu should attempt to do 'finish'

@RHEmployee
Copy link
Collaborator

Hello. Looks great.

@psss Do you have plans to allow modules to extend menu of provided choices?

For example, minute module can provide 2 types of reboot and other stuff.

@RHEmployee
Copy link
Collaborator

Another one:

people are use to use 1minutetip so maybe use r(etest) instead of t(est).

And why I should, as a user who work on test, should take care about discovery and execute step?

In case that I change fmf/tmt metadata, should I rerun discovery step manually from menu?
Maybe it should be part of t(est)? What do you think?

@psss psss marked this pull request as ready for review November 28, 2023 09:25
@psss psss self-assigned this Dec 1, 2023
@psss psss mentioned this pull request Dec 1, 2023
Open
KwisatzHaderach
KwisatzHaderach reviewed Dec 1, 2023
View reviewed changes
tmt/trying.py Outdated Show resolved Hide resolved
@psss
Copy link
Collaborator Author

psss commented Dec 1, 2023

/packit test --identifier full

@psss
Copy link
Collaborator Author

psss commented Dec 1, 2023

/packit test --identifier full

@psss
Copy link
Collaborator Author

psss commented Dec 1, 2023

So... finally all tests are green and the checklist is done. @lukaszachy, @thrix, @happz, @kkaarreell, @KwisatzHaderach, @janhavlin, @therazix, please have a look & give it a try ;-)

happz
happz reviewed Dec 4, 2023
View reviewed changes
tmt/utils.py Outdated Show resolved Hide resolved
happz
happz reviewed Dec 4, 2023
View reviewed changes
tmt/utils.py Outdated Show resolved Hide resolved
happz
happz reviewed Dec 4, 2023
View reviewed changes
tmt/trying.py Outdated Show resolved Hide resolved
happz
happz reviewed Dec 4, 2023
View reviewed changes
tmt/trying.py Outdated Show resolved Hide resolved
happz
happz reviewed Dec 4, 2023
View reviewed changes
tmt/trying.py Outdated Show resolved Hide resolved
happz
happz reviewed Dec 4, 2023
View reviewed changes
tmt/trying.py Outdated Show resolved Hide resolved
@psss psss requested a review from happz December 4, 2023 16:19
@psss
Copy link
Collaborator Author

psss commented Dec 4, 2023

/packit test --identifier full

@psss psss added the priority | must high priority, must be included in the next release label Dec 4, 2023
@psss
Copy link
Collaborator Author

psss commented Dec 5, 2023

/packit test --identifier full

@psss
Implement tmt try for interactive sessions
5b7f892 
Basic functionality for the new `tmt try` command to be used for
test development in an interactive session. Supports running tests
from the current working directory as well as quick experimenting
with selected distro image and provision method. Simple user plan
config is included as well.
@psss
Copy link
Collaborator Author

psss commented Dec 5, 2023

/packit test --identifier full

@psss psss merged commit 5b7f892 into main Dec 5, 2023
21 checks passed
@psss psss deleted the try branch December 5, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@kkaarreell kkaarreell Awaiting requested review from kkaarreell

@RHEmployee RHEmployee Awaiting requested review from RHEmployee

@therazix therazix Awaiting requested review from therazix

@bajertom bajertom Awaiting requested review from bajertom

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

Assignees

@psss psss

Labels
command | try tmt try command priority | must high priority, must be included in the next release
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@psss @lukaszachy @RHEmployee @happz @KwisatzHaderach