Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default test pidfile directory to /var/tmp #2432

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

happz
Copy link
Collaborator

@happz happz commented Oct 26, 2023

The original path, /var/tmp/tmt, may not always exist or may have unexpected permissions, preventing the pidfile from being created when less privileged account is used to access a guest.

Pull Request Checklist

  • implement the feature

@happz happz added the step | execute Stuff related to the execute step label Oct 26, 2023
@happz happz added this to the 1.29 milestone Oct 26, 2023
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tests/execute/reboot/out-of-session seems to be failing.

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now.

@psss psss self-assigned this Oct 31, 2023
The original path, `/var/tmp/tmt`, may not always exist or may have
unexpected permissions, preventing the pidfile from being created when
less privileged account is used to access a guest.
@psss psss merged commit 7552550 into main Oct 31, 2023
16 checks passed
@psss psss deleted the change-tmt-test-pid-root branch October 31, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step | execute Stuff related to the execute step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants