Fix PHP8.2 deprecated warnings in getHtmlDomArray() in tcpdf.php #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Johnson Nallori <[email protected]>
williamdes
reviewed
Feb 19, 2024
support old php versions Co-authored-by: William Desportes <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 69.28% 69.34% +0.06%
==========================================
Files 128 128
Lines 26961 27029 +68
==========================================
+ Hits 18679 18744 +65
- Misses 8282 8285 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
williamdes
approved these changes
Feb 20, 2024
|
Can anyone please Merge my PR ? |
Please be patient, @nicolaasuni does merged every some months :) |
|
This a been fixed in 6.7.3. but I had to return a non-empty array to avoid #699, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that the $html variable is either null or has any falsy value, we promptly return an empty array. This optimization not only ensures that we avoid executing the entire function but also addresses the E_DEPRECATED warning associated with passing null to the preg_match_all function, contributing to improved performance and code stability.
Fixes #670