Skip to content

Commit

Permalink
Raise minimum PHP version to 5.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@nicolaasuni
nicolaasuni committed Mar 18, 2024
1 parent 3ae08a3 commit 883cbb4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/tests.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,10 @@ jobs:
coverage-extension: ["none"]
# Add more specific tests
include:
- { php-version: '5.3', experimental: false, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'xdebug' }
- { php-version: '5.4', experimental: false, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'xdebug' }
- { php-version: '5.5', experimental: false, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'xdebug' }
- { php-version: '5.6', experimental: false, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'xdebug' }
- { php-version: '7.0', experimental: false, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'xdebug' }
- { php-version: '8.2', experimental: false, os: macos-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'none' }
#- { php-version: '8.2', experimental: false, os: macos-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'none' }
- { php-version: '8.2', experimental: false, os: windows-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'none' }
- { php-version: '8.3', experimental: true, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'pcov' }
- { php-version: 'nightly', experimental: true, os: ubuntu-latest, php-extensions: 'bcmath, imagick, gd', coverage-extension: 'pcov' }
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.TXT
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- Fix security issue.
- [BREAKING CHANGE] The tcpdf HTML tag syntax has changed, see example_049.php.
- New K_ALLOWED_TCPDF_TAGS configuration constant to set the allowed methods for the tcdpf HTML tag.
- Raised minimum PHP version to PHP 5.5.0.

6.6.5 (2023-09-06)
- Fix corrupted file.
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}
],
"require": {
"php": ">=5.3.0"
"php": ">=5.5.0"
},
"autoload": {
"classmap": [
Expand Down

3 comments on commit 883cbb4

@Muzammil1234
Copy link

@Muzammil1234 Muzammil1234 commented on 883cbb4 Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! i was previously using the TCPDF version 6.6.5 and it was working fine but not since the update to 6.7.2 i am getting the error of Undefined Array Key -1 on MultiCell.
$document->MultiCell('', '', '', 0, 'L', 0, 1, 35.5, '', true, 0, true, true,0, 'T', false);
But with 6.6.5 it works like a charm! i am using this Multicell to add a blank row in my pdf!

@Muzammil1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We are using the php version 8.1 and before the update we were using the tcpdf verison 6.6.5 and it was working like a charm. Now after the update to 6.7.2 its giving exception. I am pasting the stack trace
[2024-03-20 11:54:01] local.ERROR: Undefined array key -1 {"exception":"[object] (ErrorException(code: 0): Undefined array key -1 at /var/www/html/vendor/tecnickcom/tcpdf/tcpdf.php:18829)
[stacktrace]
#0 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(255): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError()
#1 /var/www/html/vendor/tecnickcom/tcpdf/tcpdf.php(18829): Illuminate\Foundation\Bootstrap\HandleExceptions->Illuminate\Foundation\Bootstrap\{closure}()
#2 /var/www/html/vendor/tecnickcom/tcpdf/tcpdf.php(5934): TCPDF->writeHTML()
#3 /var/www/html/app/Exports/PdfGeneration.php(121): TCPDF->MultiCell()
#4 /var/www/html/app/Exports/MonthlyBalancePdfExport.php(64): App\Exports\PdfGeneration->addBlankCell()
I am using MultiCell to create an empty row. But after the upgrade its not working.
Can you help with this? thank you :)

@williamdes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue @Muzammil1234

Please sign in to comment.