-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix prettier, move pages, add husky #14
Conversation
✅ Deploy Preview for twc-site-nl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Praise: Thanks for introducing Prettier @isabellabrookes that is a really positive change ✨ Suggestion (non-blocking): Perhaps it would be worth adopting a GitHub action to lint the changes to avoid regressions being introduced by folks who opt of git hooks |
@isabellabrookes do you feel strongly about precommit hooks? I have a preference for merge checks vs. precommit. Happy to describe the reasons why, but shortcutting the conversation by asking the question first. I'm happy to make/push a Github Action for prettier as a pre merge check since I'm asking for the alternative. |
@thisislawatts & @b-n I initially had a GHA, but then I dropped it because I thought I was adding too much. Techincally, the githook is optional. You don't have to run Options:
|
@isabellabrookes Opt 3 has my preference. LMK if I can help with anything, and much appreciation for this work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst here I thought I'd check file by file (otherwise I'm a hypocrit at work 😅).
"Request changes" per the GHA discussion.
There is a question around events.[yaml|json] I have 🤔
The other comments are mostly just so I remember to make issues. Found this along the way: https://github.com/adamzapasnik/prettier-plugin-erb (for a new PR though)
@@ -1,12 +0,0 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmmmm. Site still works without this?
There is an admin page here: https://techwerkers.nl/admin/ and I'm wondering if this file is needed there,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I yolo-ed. It didn't break my the docker env. I don't have access to netlify, so I'm not sure it's something I can check. Can we use the preview: https://deploy-preview-14--twc-site-nl.netlify.app/admin ?
@@ -1,12 +0,0 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previous comment too
b76c277
to
7a7d958
Compare
5e49940
to
df64daa
Compare
|
2261c9a
to
9a70bde
Compare
81ea76a
to
5f30288
Compare
48f6038
to
4b7aac2
Compare
4b7aac2
to
fd2753b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last little bit to discuss with the action. The rest of the changes are ✅
Co-authored-by: Ben Naylor <[email protected]>
Co-authored-by: Ben Naylor <[email protected]>
_pages/
to clean up root