Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mm.007 create a footer #6

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Mm.007 create a footer #6

merged 2 commits into from
Jul 31, 2024

Conversation

sun-amy
Copy link
Collaborator

@sun-amy sun-amy commented Jul 31, 2024 •
edited
Loading

Added a Footer folder with a Footer.tsx file. Footer includes the name 'MarsioKart' as well as a credit link to the NASA APIs.

image

Things to Check

  • Have all the requirements of your ticket have been met
  • Have you added tests if needed for your ticket
  • Are all the tests passing

Note: made a small change to the App.test.tsx file, as original test was failing due to multiple instances of 'MarsioKart' being found.

Kiran-R-K
Kiran-R-K approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job - ✅

@sun-amy sun-amy merged commit 787bd94 into main Jul 31, 2024
1 check passed
@sun-amy sun-amy deleted the mm.007-create-a-footer branch July 31, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiran-R-K Kiran-R-K Kiran-R-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sun-amy @Kiran-R-K