Replace require 'fs' with fs.coffee exporting graceful-fs #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this module always deal with lots and lots of static files I believe it is a good idea to add a central point where all fs calls can be traced/inspect/modifed/patched/whatever. In this commit I'm simply replacing all `require 'fs'` found in the codebase with require `require './fs.coffee' which now simply exports the `graceful-fs` module. This is to combat the EMFILE issue: techpines#94
|
Just noticed that some tests were failing, fixing .... EDIT: Weird, ran again and everything's all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this module always deal with lots and lots of static files
I believe it is a good idea to add a central point where all fs
calls can be traced/inspect/modifed/patched/whatever.
In this commit I'm simply replacing all
require 'fs'found inthe codebase with require
require './fs.coffee' which now simply exports thegraceful-fs` module.This is to combat the EMFILE issue: #94