Updated to work with the latest version of Browserify #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browserify v2 doesn't work with .coffee files out of the box, so all BrowserifyAsset tests have been switched to server js files instead.
|
Thanks for your work on this. It looks like substack's solution to bundling coffee is to use coffeeify: browserify/browserify#309 |
|
Awesome, thanks for the heads up. Going to close this pull request, get coffee files back working again, bump the uglify version as well, and then submit a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #98
I think this is actually a breaking change because Browserify no longer bundles .coffee files out of the box, so anyone using the BrowserifyAsset to serve .coffee files would be hosed.
One thing I wanted to mention was I wasn't sure what to do on line 25 of
lib/modules/browserify.coffeeif an error was passed to the callback. Any suggestions?