add bind:inputEl to textarea in TextField #531
Conversation
|
|
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| @@ -366,7 +367,7 @@ | |||
| {max} | |||
| {step} | |||
| {actions} | |||
| bind:inputEl | |||
| bind:inputEl={null, (el) => (inputEl = el ?? null)} | |||
There was a problem hiding this comment.
this is using function bindings as defined here. The problem was that svelte thought we wanted to provide the value from TextField to Input, and since inputEl now may be a TextArea it was not happy with that since there's missing properties. This ensures that data flow is only one way out of the Input and into the TextField variable. I would have put a comment in code but there's not a good way to do that here.
There was a problem hiding this comment.
Thanks @hahn-kev. As of right now Svelte UX supports Svelte 3-5 (and will be for 1.x, but will be Svelte 5 only). I plan to release Svelte UX 1.0 VERY soon (maybe later this week) and have a PR that has started the migration to Svelte 5, but there is a lot of regression testing and refinements that need done.
With that said, we won't be able to use Svelte 5 function bindings yet (the docs are running Svelte 5 so it succeeds).
Here's my rough plan for Svelte UX 2.x (and others). Once we start the next branch I would love to include this, and plan to have incremental releases.
There was a problem hiding this comment.
Ahh ok, I didn't realize that was a svelte 5 feature. I've changed this to do the same thing but an object to act as a wrapper which lets us define a setter without a getter.
There was a problem hiding this comment.
Nice technique! Care to run pnpm format to fix the prettier lint issue and I'll merge / release.
There was a problem hiding this comment.
Also, could you add an example or a way to validate the change. I don't have any component tests at the moment, just some unit tests and a lot of examples for visual/manual validation
There was a problem hiding this comment.
fixed the lint issues. FYI maybe this is because I'm on windows, but when I ran format it modified 486 files, in addition to the TextField file. I only checked in that one. That might trip up others though, I think it might be a BOM issue, but it's hard to tell what the changes are.
There was a problem hiding this comment.
Alright there's now also an example (really like how that system was designed btw, really cool), here's a screenshot of it, I figured I should include a toggle between single and multi-line since that's what this PR was mainly for.
|
I still see some lint issues, but I'll fix them after merging. Thanks for the PR! |
|
Actually the failure was due to a test setup (and unrelated to this PR) |
|
Released as 0.77.1. Thanks again! |
closes #357
I didn't test this as I just checked out this repo for this simple change, I'm assuming CI will catch any issues this causes (if any)