-
-
Notifications
You must be signed in to change notification settings - Fork 51
feat: add change event on rangeslider #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add change event on rangeslider #104
Conversation
fix: always show limit option on range slider fix: always show values option on rangeslider
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @percybolmer. I left a few comments. Also, full disclosure, I'm not overlay happy with how this component is currently implemented, and is likely going to be reworked (and at least renamed to MultiRangeInput
). See this issue for some of my thoughts. It also has a few bugs I'm aware of.
I recently added RangeField but it's only single value, and also not documented (not finished). It's mostly used for some doc examples ATM (and needs to be refined, and the range styled.
I see! I gotta say that I love that svelte UX provides a RangeSlider instead of only a Single value slider! |
Yeah, I like it, just needs some TLC, and been low on my priority list. Btw, if this one doesn't fit your needs (for now), you might want to take a look at https://github.com/simeydotme/svelte-range-slider-pips. I definitely want to get this impl. working great through (and improve the accessibility further). |
@percybolmer I'm going to close this for now, but feel free to re-open and rebase off |
This PR adds
change
events to fire from the RangeSlider.Also adds two options
display_values
- When set to true always displays valuesdisplay_limits
- When set to true always displays MIN/MAX at the top corners