fix(Drawer|Dialog): No longer stop mouseup event propgation, which fi…

…xes closing Menu by clicking outside (within Dialog/Drawer) (#499)
techniq · Oct 20, 2024 · cfcb1b5 · cfcb1b5
1 parent 8af7ebb
commit cfcb1b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.changeset/many-tigers-add.md b/.changeset/many-tigers-add.md
@@ -0,0 +1,5 @@
+---
+'svelte-ux': patch
+---
+
+fix(Drawer|Dialog): No longer stop mouseup event propgation, which fixes closing Menu by clicking outside (within Dialog/Drawer)
diff --git a/packages/svelte-ux/src/lib/components/Dialog.svelte b/packages/svelte-ux/src/lib/components/Dialog.svelte
@@ -99,10 +99,6 @@
       classes.root
     )}
     on:click={onClick}
-    on:mouseup={(e) => {
-      // Do not allow event to reach Popover's on:mouseup (clickOutside)
-      e.stopPropagation();
-    }}
     on:keydown={(e) => {
       if (e.key === 'Escape') {
         // Do not allow event to reach Popover's on:keydown

diff --git a/packages/svelte-ux/src/lib/components/Drawer.svelte b/packages/svelte-ux/src/lib/components/Drawer.svelte
@@ -106,10 +106,6 @@
         close();
       }
     }}
-    on:mouseup={(e) => {
-      // Do not allow event to reach Popover's on:mouseup (clickOutside)
-      e.stopPropagation();
-    }}
     use:portalAction={portal}
     use:focusMove={{ restoreFocus: true }}
     role="dialog"