⚡ UPDATE: integer

techniq · Nov 16, 2023 · bd158c6 · bd158c6
1 parent b9a7fc0
commit bd158c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/svelte-ux/src/lib/utils/number.test.ts b/packages/svelte-ux/src/lib/utils/number.test.ts
@@ -66,8 +66,7 @@ describe('formatNumber()', () => {
 
   it('formats number with integer', () => {
     const actual = formatNumber(1234.5678, { style: 'integer' });
-    expect(actual).equal('1234');
-    // expect(actual).equal('1,234'); // TODO: Today its like this... It's intended? (I leave the test breaking for now)
+    expect(actual).equal('1,235');
   });
 
   it('formats number with default fraction digits', () => {

diff --git a/packages/svelte-ux/src/lib/utils/number.ts b/packages/svelte-ux/src/lib/utils/number.ts
@@ -36,10 +36,6 @@ export function formatNumber(
     return `${number}`;
   }
 
-  if (options.style === 'integer') {
-    return `${parseInt(number.toString())}`;
-  }
-
   // todo set defaults in a context or something
   const defaults: FormatNumberOptions = {
     locales: 'en',
@@ -82,6 +78,13 @@ export function formatNumber(
       minimumFractionDigits: 0,
       maximumFractionDigits: 0,
     }),
+
+    // Let's overwrite for style=metric
+    ...(options.style === 'integer' && {
+      style: 'decimal',
+      minimumFractionDigits: 0,
+      maximumFractionDigits: 0,
+    }),
   });
   const value = formatter.format(number);