Skip to content

Commit

Permalink
[SelectField] Do not allow wrapping button container to be keyboard…
Browse files Browse the repository at this point in the history
… focusable
  • Loading branch information
techniq committed Jul 16, 2024
1 parent e19e7dd commit 95447db
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/serious-boxes-rush.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte-ux': patch
---

[SelectField] Do not allow wrapping `button` container to be keyboard focusable
2 changes: 1 addition & 1 deletion packages/svelte-ux/src/lib/components/SelectField.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,6 @@
}
</script>

<!-- svelte-ignore a11y-click-events-have-key-events -->
<button
type="button"
aria-haspopup={!inlineOptions ? 'listbox' : undefined}
Expand All @@ -424,6 +423,7 @@
)}
bind:this={selectFieldEl}
on:click={onClick}
tabindex="-1"
>
<TextField
{label}
Expand Down

0 comments on commit 95447db

Please sign in to comment.