CHI-3295: use new prepopulate config in Twilio Lambda #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency so flex can import it
GPaoloni
approved these changes
May 16, 2025
There was a problem hiding this comment.
LGTM.
One question: I see that only the Lambda version of pre-populate is updated here. Does this means that we intend to deploy this only after all accounts are relying on "backend contact creation"? If that's the case, could we also remove all the code regarding Flex contact creation as cleanup PR?
| @@ -24,16 +24,16 @@ ENV lambda_name ${lambda_name} | |||
| # copy the hrm-lib package and labmdas folders so that the file: based | |||
| # dependency in package.json can be resolved | |||
| COPY ${lambda_dir}/${lambda_name} /tmp/build/${lambda_dir}/${lambda_name} | |||
| COPY ${lambda_dir}/../packages /tmp/build/${lambda_dir}/../packages | |||
There was a problem hiding this comment.
There are a few github lint notes up in this file, maybe address them?
| const { preEngagement: preEngagementKeys, survey: surveyKeys }: PrepopulateKeys = | ||
| await loadConfigJson(formDefinitionRootUrl, 'PrepopulateKeys'); | ||
|
|
||
| const isValidSurvey = Boolean(answers?.aboutSelf); // determines if the memory has valid values or if it was aborted |
There was a problem hiding this comment.
The ticket says
with no chatbot survey at all, the pre-engagement form should be used to prepopulate both the caller and child tabs.
I thought aboutSelf will be supported from preEngagementData too. Shouldn't that be the case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P