Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ta-730): add partitioned cookie config #77

Closed
wants to merge 3 commits into from

Conversation

mike-dean-talis
Copy link
Contributor

@mike-dean-talis mike-dean-talis commented Apr 22, 2024

Problem

On analysing Elevate's use of LTI.js, we identified that it requires third party cookies. The library has not yet been updated to change this particular feature.

In order for LTI launches to continue to work in Elevate (at least for Chrome-based browsers), we require a solution that allows these cookies to be processed in a PKCE workflow.

The current solution to this issue is partioned cookies.

Elevate cannot support this at an LTI.js level, nor at the Express.js level so we must resort to a supporting configuration in nginx.

This new property will load a supporting nginx configuration.

@mike-dean-talis mike-dean-talis added the 30% 30% Code Review label Apr 22, 2024
@mike-dean-talis mike-dean-talis self-assigned this Apr 22, 2024
@mike-dean-talis mike-dean-talis changed the title feat(ta-730): Add partitioned cookie config feat(ta-730): add partitioned cookie config Apr 22, 2024
@mike-dean-talis mike-dean-talis requested a review from a team April 23, 2024 11:38
@mike-dean-talis
Copy link
Contributor Author

comment: I am looking for some critique and advice for this PR.

I am not sure if I am:

  • Configuring nginx to do what we're after (hopefully that's clear from the PR description)
  • A good guide to actually testing this

Copy link
Member

@mrliptontea mrliptontea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a test with multiple locations? I want to ensure each entry location directive starts on its own line.

@mrliptontea mrliptontea deleted the ta-730-pkce-partitioned-cookies branch June 11, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30% 30% Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants