Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Pods with multiple containers #76

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

mrliptontea
Copy link
Member

  • Add containers prop to ContainerProps to allow specifying multiple container Pods.
  • Remove tsc lint from precommit hook because it's failing on linting test files due to how tsc-files works
    test/background-worker/background-worker.test.ts(175,26): error TS2551: Property 'toHaveAllProperties' does not exist on type 'Assertion<any>'.
    
  • Correct vitest.config.mts file name and in tsconfig.json.

@mrliptontea mrliptontea requested a review from a team March 28, 2024 10:50
Copy link
Member

@kiyanwang kiyanwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually thought this was going to be a little more complex, I had to walk the tests back through to the JobProps to see how multiple container tests were adding the additional container to the requiredProps.

nice!

@mrliptontea mrliptontea merged commit 526214c into main Mar 28, 2024
8 checks passed
@mrliptontea mrliptontea deleted the support-pods-with-multiple-containers branch March 28, 2024 13:06
@talisaspire
Copy link
Collaborator

🎉 This PR is included in version 4.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants