Merge pull request #5 from talis/ExtraBrowserProps

Added BROWSER_OS & BROWSER_MOBILE to event
techfromsage · Nov 2, 2018 · 274a562 · 274a562
2 parents 60a2459 + 021b72f
commit 274a562
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 1.2.3 (2018-11-02)
+
+Features:
+
+  - Send additional browser info to Echo
+
 ## 1.2.1 (2016-02-24)
 
 Bug fixes:

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "echo-angular",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "main": "./js/echo.services.js",
   "description": "Client for Talis Echo",
   "repository": {

diff --git a/js/echo.services.js b/js/echo.services.js
@@ -8,7 +8,19 @@ angular.module('talis.services.echo', []).factory("echo",[
     "APP_ID",
     "BROWSER_NAME",
     "BROWSER_VERSION",
-    "BROWSER_COMPAT_MODE", function($rootScope, $http, applicationLoggingService,ECHO_ENDPOINT,APP_ID,BROWSER_NAME,BROWSER_VERSION,BROWSER_COMPAT_MODE) {
+    "BROWSER_COMPAT_MODE",
+    "BROWSER_OS",
+    "BROWSER_MOBILE",
+    function($rootScope,
+        $http,
+        applicationLoggingService,
+        ECHO_ENDPOINT,
+        APP_ID,
+        BROWSER_NAME,
+        BROWSER_VERSION,
+        BROWSER_COMPAT_MODE,
+        BROWSER_OS,
+        BROWSER_MOBILE) {
         var instance = function() {};
         var MAX_FLUSH_EVENTS = 10;
         var DEBOUNCE_INTERVAL = 2500;
@@ -98,6 +110,8 @@ angular.module('talis.services.echo', []).factory("echo",[
             event.props.browser_name = BROWSER_NAME;
             event.props.browser_version = BROWSER_VERSION;
             event.props.browser_compat_mode = BROWSER_COMPAT_MODE;
+            event.props.browser_os = BROWSER_OS;
+            event.props.browser_mobile = BROWSER_MOBILE;
             if ($rootScope.user !==null && $rootScope.user.guid !==null) {
                 event['user'] = $rootScope.user.guid;
             }